PCL private linkage: avoid Qt5/6 conflicts #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have restored all Qt references (now to Qt6) and MOC so that RViz can load the NavMap plugin correctly (MapDisplay and 2DGoalPose tested in simulation). |
Member
|
After many trials, we have opted for migrating everything to Qt6, because supporting both Qt5 and Qt6 was giving us problems in some machines (mine). The current state of the PR looks good to me and should work (waiting for CI), but still it would be good to do some aditional tests before merging @fmrico. Thank you @estherag for the nice work! |
Butakus
approved these changes
Feb 9, 2026
Member
|
Merging! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
RViz no longer supports Qt5, which caused a version conflict with PCL (linked to VTK9/Qt5) in navmap_ros.
Marking the PCL linkage as private stops Qt5 headers from propagating, so RViz plugins can use Qt6 (preventing compilation errors as #8).
Best,
Esther